Skip to content

feat!: remove runtime module deprecated properties#12684

Merged
LingyuCoder merged 2 commits intov2from
feat/remove-runtime-module-properties
Jan 9, 2026
Merged

feat!: remove runtime module deprecated properties#12684
LingyuCoder merged 2 commits intov2from
feat/remove-runtime-module-properties

Conversation

@LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Jan 9, 2026

Summary

Remove deprecated properites of JS runtime module.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@LingyuCoder LingyuCoder requested a review from hardfist as a code owner January 9, 2026 02:57
@netlify
Copy link

netlify bot commented Jan 9, 2026 •
edited
Loading

✅ Deploy Preview for rspack-v2 canceled.

Name Link
🔨 Latest commit 4641a1f
🔍 Latest deploy log https://app.netlify.com/projects/rspack-v2/deploys/69606eb6da1f5c00087c2ccc

@LingyuCoder LingyuCoder changed the title feat: remove runtime module deprecated properties feat!: remove runtime module deprecated properties Jan 9, 2026
@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 9, 2026
@LingyuCoder LingyuCoder added the release: breaking change release: breaking change related release(mr only) label Jan 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 3 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -8.0 B (-0.0%)
react-1k 825.4 KB 0
react-5k 2.7 MB +1.0 B (0.0%)
rome 986.0 KB +1.7 KB (0.2%)
ui-components 2.1 MB 0
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: 29642b28fd | PR: #12659

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB -8.0 B (-0.0%)
📄 JavaScript 5.7 MB 5.7 MB -8.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: 29642b28fd | PR: #12659

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB +1.0 B (0.0%)
📄 JavaScript 2.7 MB 2.7 MB +1.0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: 29642b28fd | PR: #12659

Metric Current Baseline Change
📊 Total Size 986.0 KB 984.3 KB +1.7 KB (0.2%)
📄 JavaScript 986.0 KB 984.3 KB +1.7 KB (0.2%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: rome Bundle Diff

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

📦 Binary Size-limit

Comparing 4641a1f to refactor: use DerfOpt's take/replace assist artifact mutation (#12659) by pshu

🎉 Size decreased by 356.13KB from 47.87MB to 47.53MB (⬇️0.73%)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 9, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing feat/remove-runtime-module-properties (4641a1f) with v2 (10d30ed)

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@LingyuCoder LingyuCoder requested a review from SyMind January 9, 2026 05:01
@LingyuCoder LingyuCoder merged commit 45d4892 into v2 Jan 9, 2026
108 of 112 checks passed
@LingyuCoder LingyuCoder deleted the feat/remove-runtime-module-properties branch January 9, 2026 06:07
LingyuCoder added a commit that referenced this pull request Jan 14, 2026
@LingyuCoder
feat!: remove runtime module deprecated properties (#12684)
d85ae6c 
* feat: remove runtime module deprecated properties

* feat: remove runtime module deprecated properties
LingyuCoder added a commit that referenced this pull request Jan 15, 2026
@LingyuCoder
feat!: remove runtime module deprecated properties (#12684)
b44ccdf 
* feat: remove runtime module deprecated properties

* feat: remove runtime module deprecated properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SyMind SyMind SyMind approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

Assignees

No one assigned

Labels

release: breaking change release: breaking change related release(mr only) release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LingyuCoder @SyMind